Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Expand a thread reply test to be more explicit #11502

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Aug 31, 2023

Part of element-hq/element-web#25449


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 31, 2023
@andybalaam andybalaam force-pushed the andybalaam/break-up-thread-reply-test branch from e4524b3 to cbcf9e8 Compare September 1, 2023 16:08
Base automatically changed from andybalaam/just-fix-edit to develop September 4, 2023 16:58
@andybalaam andybalaam force-pushed the andybalaam/break-up-thread-reply-test branch from cbcf9e8 to 8b08ec9 Compare September 6, 2023 07:26
@andybalaam
Copy link
Member Author

Flaky test caused the failure, re-running.

@andybalaam
Copy link
Member Author

Flaky test caused the failure, re-running.

Actually I don't think it was flaky - I think it was the same thing @BillCarsonFr was seeing the other day, where the case of "Sign in" vs "Sign In" was different.

I think this might have been fixed in the meantime, so trying again seems a good idea either way.

@andybalaam andybalaam marked this pull request as ready for review September 8, 2023 00:32
@andybalaam andybalaam requested a review from a team as a code owner September 8, 2023 00:32
@andybalaam andybalaam enabled auto-merge September 8, 2023 02:24
@andybalaam andybalaam added this pull request to the merge queue Sep 9, 2023
Merged via the queue into develop with commit a621dfa Sep 9, 2023
23 checks passed
@andybalaam andybalaam deleted the andybalaam/break-up-thread-reply-test branch September 9, 2023 07:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants